v2.1.x: TCP BTL fixes #3078
Merged
v2.1.x: TCP BTL fixes #3078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly for error cases, where we need to release the newly created proc. Currently the code deadlocks because the endpoint lock is help at the release and the lock is not recursive. Aslo added some code to print the IP addresses that don't match during the TCP connection step. Thanks to Evgueni Petrov @Welcome-Dear-Evgueni for reporting the issue. Signed-off-by: George Bosilca <[email protected]> (cherry picked from commit ec4a235) Signed-off-by: Jeff Squyres <[email protected]>
Signed-off-by: George Bosilca <[email protected]> (cherry picked from commit b0f8d2c)
Make the message more friendly / more detailed, and de-duplicate it (just in case it happens a lot). Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 5b484c9)
jsquyres
force-pushed
the
pr/v2.1.x/bosilica-fixes
branch
from
a149dae to
a0d29ac
Compare
Merged
bosilca
approved these changes
Mar 2, 2017
|
@hppritcha I think this PR is worthy of v2.1.0; we can discuss and see if you agree. It is not vital to get into tonight's MTT, but is still fixing some real bugs, and paving the way to get more information to solve #3035. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes from @bosilca on master:
free()a buffer on the stack.@bosilca I had to fix a conflict when porting over the #3042 fix. It seems to work, but I'd appreciate your review.
@hppritcha I marked this as for v2.1.0 because it fixes a real bug that a user encountered (thanks to Evgueni Petrov @Welcome-Dear-Evgueni for reporting).