OSHMEM v1.3: adds fetch and set amos and c11 generic #2123
Conversation
|
@alex-mikheev Same comments I just made in #2122 (comment) |
jsquyres
changed the title
|
This is not merged on master yet -- wait until #2122 is merged and tested. |
|
#2122 has been merged. |
| * All rights reserved. | ||
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * All rights reserved. | ||
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow | ||
| * |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * All rights reserved. | ||
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * All rights reserved. | ||
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * |
There was a problem hiding this comment.
@alex-mikheev please update the header
| * Copyright (c) 2013 Cisco Systems, Inc. All rights reserved. | ||
| * $COPYRIGHT$ | ||
| * | ||
| * Additional copyrights may follow |
There was a problem hiding this comment.
@alex-mikheev please update the header
|
@igor-ivanov @alex-mikheev FWIW: I use a git hook to verify that I've updated my copyrights; it blocks my commits until I've updated the copyrights properly. In my #!/bin/sh
#
# Called by "git commit" with no arguments. The hook should
# exit with non-zero status after issuing an appropriate message if
# it wants to stop the commit.
function die() {
rc=$1
shift;
printf "*** GIT PRE-COMMIT HOOK FAILED ***:\n"
echo "$@"
exit $rc
}
if git rev-parse --verify HEAD >/dev/null 2>&1
then
against=HEAD
else
# Initial commit: diff against an empty tree object
against=4b825dc642cb6eb9a060e54bf8d69288fbee4904
fi
# Redirect output to stderr.
exec 1>&2
# If there are whitespace errors, print the offending file names and fail.
echo "=== Checking for whitespace errors..."
git diff-index --check --cached $against -- || die $? "whitespace errors"
# If we have a copyright-checking script, run it
if test -x ./contrib/update-my-copyright.pl; then
echo "=== Checking copyrights..."
./contrib/update-my-copyright.pl --check-only --quiet || die $? "Copyrights are not up to date"
else
echo "=== No update-my-copyright.pl script -- skipping"
fi |
jsquyres
changed the title
|
@jladd-mlnx @igor-ivanov @alex-mikheev The copyrights still aren't updated, and this PR now has conflicts. I suspect it needs to be rebased now that #2095 (the first of the OSHMEM PRs) was merged. |
The commit adds atomic set and fetch functions as described in oshmem 1.3 spec. (cherry picked from commit 3a03435)
add missing put*/get* functions. Move *put|get16 functions from shmemx.h to shmem.h as required by 1.3 spec. (cherry picked from commit 9a21392) removes fortran shmem_put() because v1.3 does not have it
alex-mikheev
force-pushed
the
topic/oshmem_c11_generics_v2.x
branch
from
390f496 to
f5297cc
Compare
|
@jladd-mlnx @igor-ivanov please take a look |
|
👍 |
1 similar comment
|
👍 |
@jladd-mlnx @igor-ivanov
based on #2122 with changes for the v2.x branch