OSHMEM v1.3: c11 generics (DNM before #2103) #2122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds atomic set and fetch functions as described in oshmem 1.3 spec.
add missing put*/get* functions. Move *put|get16 functions from shmemx.h to shmem.h as required by 1.3 spec.
bertwesarg
reviewed
Sep 26, 2016
| long long*: pshmem_longlong_iput, \ | ||
| float*: pshmem_float_iput, \ | ||
| double*: pshmem_double_iput, \ | ||
| long double*: pshmem_longdouble_iput)(dst, src, len, pe) |
There was a problem hiding this comment.
This call does not match the macros arguments.
| long long*: pshmem_longlong_g, \ | ||
| float*: pshmem_float_g, \ | ||
| double*: pshmem_double_g, \ | ||
| long double*: pshmem_longdouble_g)(addr, val, pe) |
| long long*: shmem_longlong_iput, \ | ||
| float*: shmem_float_iput, \ | ||
| double*: shmem_double_iput, \ | ||
| long double*: shmem_longdouble_iput)(dst, src, len, pe) |
| long long*: shmem_longlong_g, \ | ||
| float*: shmem_float_g, \ | ||
| double*: shmem_double_g, \ | ||
| long double*: shmem_longdouble_g)(addr, val, pe) |
bertwesarg
reviewed
Sep 26, 2016
| long long*: pshmem_longlong_p, \ | ||
| float*: pshmem_float_p, \ | ||
| double*: pshmem_double_p, \ | ||
| long double*: shmem_longdouble_p)(dst, val, pe) |
There was a problem hiding this comment.
that should be pshmem_longdouble_p
jsquyres
changed the title
|
@alex-mikheev Thanks for the fixes. Can you squash down those 2 "fix" comments into their appropriate original commit(s)? (i.e., no need to have a PR that adds fixes to commits that were introduced in the same PR) |
|
sure i will squash 'fixes commits' |
|
Merging this. |
clementFoyer
pushed a commit
to bosilca/ompi
that referenced
this pull request
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jladd-mlnx @igor-ivanov please review
Note that PR depends on #2103