Skip to content

Don't accept UCX < 1.9 #13028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Don't accept UCX < 1.9 #13028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions config/ompi_check_ucx.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,18 @@ AC_DEFUN([OMPI_CHECK_UCX],[

AS_IF([test "$ompi_check_ucx_happy" = yes],
[# Turn off UCX version v1.8 due to issue #8321
AC_CACHE_CHECK([UCX version 1.8.x],
[ompi_check_ucx_cv_have_version_1_8],
AC_CACHE_CHECK([UCX version > 1.9.x],
[ompi_check_ucx_cv_have_version_gt_1_9],
[AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
#include <ucp/api/ucp_version.h>
]], [[
#if (UCP_API_MAJOR == 1) && (UCP_API_MINOR == 8)
#error "Invalid version"
#endif
]])],
[ompi_check_ucx_cv_have_version_1_8=no],
[ompi_check_ucx_cv_have_version_1_8=yes])])
AS_IF([test "${ompi_check_ucx_cv_have_version_1_8}" = "yes"],
[AC_MSG_WARN([UCX support skipped because version 1.8.x was found, which has a known catastrophic issue.])
ompi_check_ucx_happy=no])])
AC_PREPROC_IFELSE([AC_LANG_PROGRAM([[
#include <ucp/api/ucp_version.h>
]], [[
#if (UCP_API_MAJOR < 1) || ((UCP_API_MAJOR == 1) && (UCP_API_MINOR < 9))
#error "Version too low"
#endif
]])],
[], [AC_MSG_WARN([UCX version is too old, please upgrade to 1.9 or higher.])])
]])],
[ompi_check_ucx_cv_have_version_gt_1_9=yes],
[ompi_check_ucx_cv_have_version_gt_1_9=no
ompi_check_ucx_happy=no])])])

AS_IF([test "$ompi_check_ucx_happy" = yes],
[AC_CHECK_DECLS([ucp_tag_send_nbr],
Expand Down