Skip to content

Topic/fix same instance #12709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Topic/fix same instance #12709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b7215a
Identify requests from the same instance.
bosilca Jul 25, 2024
0a02491
Fix the access to the rcount array.
bosilca Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ompi/mca/coll/base/coll_base_alltoallv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ mca_coll_base_alltoallv_intra_basic_inplace(const void *rbuf, ompi_count_array_t
if( OPAL_UNLIKELY(opal_local_arch != ompi_proc->super.proc_convertor->master->remote_arch)) {
packed_size = opal_datatype_compute_remote_size(&rdtype->super,
ompi_proc->super.proc_convertor->master->remote_sizes);
packed_size *= rcounts[right];
packed_size *= ompi_count_array_get(rcounts, right);
max_size = packed_size > max_size ? packed_size : max_size;
}
}
Expand Down
9 changes: 5 additions & 4 deletions ompi/request/request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@ int ompi_request_persistent_noop_create(ompi_request_t** request)
bool ompi_request_check_same_instance(ompi_request_t** requests,
int count)
{
ompi_request_t *req, *base = NULL;
ompi_instance_t* base_instance = NULL;
ompi_request_t *req;

for(int idx = 0; idx < count; idx++ ) {
req = requests[idx];
Expand All @@ -262,11 +263,11 @@ bool ompi_request_check_same_instance(ompi_request_t** requests,
/* Only PML requests have support for MPI sessions */
if(OMPI_REQUEST_PML != req->req_type)
continue;
if(NULL == base) {
base = req;
if(NULL == base_instance) {
base_instance = req->req_mpi_object.comm->instance;
continue;
}
if(base->req_mpi_object.comm != req->req_mpi_object.comm)
if(base_instance != req->req_mpi_object.comm->instance)
return false;
}
return true;
Expand Down
Loading