ofi/common: close memory base in an error path #11037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wckzhang
reviewed
Nov 7, 2022
opal/mca/common/ofi/common_ofi.c
Outdated
| @@ -190,6 +190,7 @@ int opal_common_ofi_export_memory_monitor(void) | |||
| free(opal_common_ofi_monitor); | |||
| } | |||
|
|
|||
| mca_base_framework_close(&opal_memory_base_framework); | |||
There was a problem hiding this comment.
Would there be an issue of closing this if it hasn't been opened? Line 141 is a goto err before this gets opened
There was a problem hiding this comment.
good point it probably shouldn't hurt but i'll add in a sentinel.
related to open-mpi#10975 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
force-pushed
the
close_memory_base_in_ofi_err_path
branch
from
45a766a to
c9594e3
Compare
wckzhang
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #10975
Signed-off-by: Howard Pritchard [email protected]