ofi/common: release opal memory base framework #10975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when shutting down the memory monitoring infrastructure in ofi common. Signed-off-by: Howard Pritchard <[email protected]>
|
@wckzhang could you please review? I'd like to get this into the 5.0.0 release. |
awlauria
approved these changes
Nov 1, 2022
|
Can you also add closing the base framework to the opal_common_ofi_export_memory_monitor error path? |
|
@wckzhang good catch yes I'll add that in a new PR. |
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Nov 5, 2022
related to open-mpi#10975 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Nov 9, 2022
related to open-mpi#10975 Signed-off-by: Howard Pritchard <[email protected]>
hppritcha
added a commit
to hppritcha/ompi
that referenced
this pull request
Nov 11, 2022
related to open-mpi#10975 Signed-off-by: Howard Pritchard <[email protected]> (cherry picked from commit c9594e3)
yli137
pushed a commit
to yli137/ompi
that referenced
this pull request
Jan 10, 2024
related to open-mpi#10975 Signed-off-by: Howard Pritchard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when shutting down the memory monitoring infrastructure in ofi common.
Signed-off-by: Howard Pritchard [email protected]