Skip to content

autogen.pl: tweak a regexp to handle more cases #10810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

jsquyres
Copy link
Member

The output of git submodule status will be of the following form:

Xgit_hash submodule_path [(git_ref)]
  • X is either a space, +, or -
  • git_hash is 40 hex digits
  • submodule_path is the path in the repo where the submodule is located
  • (git_ref) is optional, and will not be there if the submodule is missing (which the previous regexp did not handle).

This commit tightens up the regexp to be a bit more robust and handle the case where the git_ref token is not present.

Signed-off-by: Jeff Squyres [email protected]

The output of `git submodule status` will be of the following form:

```
Xgit_hash submodule_path [(git_ref)]
```

* `X` is either a space, `+`, or `-`
* `git_hash` is 40 hex digits
* `submodule_path` is the path in the repo where the submodule is
  located
* `(git_ref)` is optional, and will not be there if the submodule is
  missing (which the previous regexp did not handle).

This commit tightens up the regexp to be a bit more robust and handle
the case where the git_ref token is not present.

Signed-off-by: Jeff Squyres <[email protected]>
@jsquyres jsquyres merged commit ee324be into open-mpi:main Sep 16, 2022
@jsquyres jsquyres deleted the pr/autogen-tweak branch September 16, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants