Op: Treat unsigned long as unsigned, not signed long #10527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This likely had no impact on arithmetic operations but bites us on min and max. We should use unsigned long consistently though. Signed-off-by: Joseph Schuchart <[email protected]>
devreal
changed the title
awlauria
approved these changes
Jun 29, 2022
This was referenced Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This likely had no impact on arithmetic operations but bites us on min and max. We should use
unsigned longconsistently though.Fixes #10525
Needs backports to 5.0.x and 4.1.x (also 4.0.x?)
Signed-off-by: Joseph Schuchart [email protected]