ompi/mca/sharedfp/sm: Include missing sys/stat.h in sharedfp_sm.c
#10385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
giordano
force-pushed
the
mg/sys-stat
branch
2 times, most recently
from
cca5014 to
193e1be
Compare
jsquyres
reviewed
May 16, 2022
Macros `S_IRUSR`, `S_IWUSR`, `S_IRGRP`, and `S_IROTH` are defined in `sys/stat.h`. See for reference <https://pubs.opengroup.org/onlinepubs/7908799/xsh/sysstat.h.html> and <https://www.gnu.org/software/libc/manual/html_node/Permission-Bits.html>. The lack of this include causes a compilation error on FreeBSD. Signed-off-by: Mosè Giordano <[email protected]>
jsquyres
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Macros
S_IRUSR,S_IWUSR,S_IRGRP, andS_IROTHare defined insys/stat.h. See for referencehttps://pubs.opengroup.org/onlinepubs/7908799/xsh/sysstat.h.html and
https://www.gnu.org/software/libc/manual/html_node/Permission-Bits.html.
The lack of this include causes a compilation error on FreeBSD.