v5.0.x: openmpi.spec: updates for v5.0.0 #10270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default all 3rd-party packages to be "external". It is strognly recomended that the RPM only contain Open MPI, not the embedded 3rd-party packages. This behavior can be overridden via the configure_options rpmbuild macros. - Copy all the Sphinx-generated HTML files to pkgdocdir/html. These are not normally installed, but it's probably worth it for the RPM. - Remove no-longer-existing INSTALL file. This file was removed as part of the conversion to RST-based documentation. - Tighten up files listings for the individual RPMs. - Convert -docs sub-package to exclusively use mandir and pkgdocdir (instead of docs.files). We already excluded mandir because rpmbuild may have renamed all the man pages after compressing them (so we didn't necessarily know the correct filenames). We also explicitly list pkgdocdir so that it picks up the entire tree of files and also removes the entire tree (including directories) when the RPM is removed. - Remove some stale F77 and VT references. - Fix some minor typos. - Fix a few "file listed twice" warnings and clean up lists of files included in the runtime and devel sub-project RPMs. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit 64a0337)
Adding "-j12" to the mflags was intended as a debuggin aid; it accidentally slipped through and was merged as part of open-mpi#10224. Signed-off-by: Jeff Squyres <[email protected]> (cherry picked from commit d034ed6)
Member
Author
|
Marking this PR as "draft" because it's going to fail the git commit checker: it includes a cherry pick of the commit from #10269, which isn't yet merged to main. #10269 was created when I was visually checking this PR before creating it, and found an issue that required another main commit to fix. Grumble. |
gpaulsen
approved these changes
Apr 13, 2022
Member
gpaulsen
left a comment
gpaulsen
left a comment
There was a problem hiding this comment.
Looks good. Not sure if the "all in one package" is worth maintaining, but it looks like you updated it correctly.
Member
Author
It sounds like both @acgoldma and @shijin-aws use the "all in one package". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recomended that the RPM only contain Open MPI, not the embedded
3rd-party packages. This behavior can be overridden via the
configure_options rpmbuild macros.
are not normally installed, but it's probably worth it for the RPM.
part of the conversion to RST-based documentation.
(instead of docs.files). We already excluded mandir because
rpmbuild may have renamed all the man pages after compressing them
(so we didn't necessarily know the correct filenames). We also
explicitly list pkgdocdir so that it picks up the entire tree of
files and also removes the entire tree (including directories) when
the RPM is removed.
included in the runtime and devel sub-project RPMs.
Signed-off-by: Jeff Squyres [email protected]
(cherry picked from commit 64a0337)