Miscellaneous cleanups #10246
Merged
Miscellaneous cleanups #10246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
bot:aws:recheck |
Member
|
bot:aws:retest |
bwbarrett
requested changes
Apr 8, 2022
Use strings/names that are meaningful to the end user, not just to the Open MPI developer. Signed-off-by: Jeff Squyres <[email protected]>
OMPI_CANONICALIZE_PATH broke on MacOS when `/usr/bin/python` disappeared (in favor of `/usr/bin/python3`) in MacOS Monterrey. Make things simpler by not canonicalizing the path to begin with. Specifically: just look at `pwd`, $srcdir, and $prefix. Even if $srcdir and/or $prefix are relative to the build dir, the union of all the checks will ensure that none of the target paths will contain spaces. Signed-off-by: Jeff Squyres <[email protected]>
Add a missing AC_MSG about SPC, and group it together with the rest of the MPI-layer options. Also put the library naming test there, since it emits a message about "libmpi_FOO". Move the OSHMEM tests down below all of that so that the output in that section solely has to do with OSHMEM tests (and not have the results of some OMPI tests tacked on to the end of that section). Finally, make some trivial whitespace fixes. Signed-off-by: Jeff Squyres <[email protected]>
Unbelievably, at least some versions of jni.h have a global symbol named "jvalue". So avoid using that name as a parameter or variable in our code. Signed-off-by: Jeff Squyres <[email protected]>
AC_HELP_STRING --> AS_HELP_STRING Signed-off-by: Jeff Squyres <[email protected]>
jsquyres
force-pushed
the
pr/misc-cleanups
branch
from
0ac149f to
0cc63a5
Compare
bwbarrett
approved these changes
May 17, 2022
This was referenced May 17, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanups found while working on #10223, #10224, and #10245. See individual commit messages, the most important of which is likely the MacOS
/usr/bin/pythonfix.