Skip to content

Conversation

vspetrov
Copy link

@vspetrov vspetrov commented Mar 31, 2022

V5.0.x version of #10208 and #10003
Signed-off-by: Valentin Petrov [email protected]

@vspetrov vspetrov requested a review from janjust March 31, 2022 21:58
@vspetrov
Copy link
Author

bot:notacherrypick

@janjust janjust changed the title v5.0.x: coll/ucc: build and warn fixes v5.0.x: coll/ucc: build and warn fixes Apr 1, 2022
@janjust janjust changed the title v5.0.x: coll/ucc: build and warn fixes v5.0.x: coll/ucc: build and warn fixes Apr 1, 2022
@janjust
Copy link
Contributor

janjust commented Apr 1, 2022

@vspetrov wouldn't it be better to just bring #10003 to v5.0.x and then cherry-pick main-branch PR? I don't see a reason why we shouldn't bring it back, for better git history

edgargabriel and others added 2 commits April 1, 2022 09:17
to retrieve the communicator context id. Makes the component compile again.

Signed-off-by: Edgar Gabriel <[email protected]>
(cherry picked from commit 6618dcf)
    c_contextid -> ompi_comm_get_local_cid
    explicit dtype map init

Signed-off-by: Valentin Petrov <[email protected]>
(cherry picked from commit 4f3257d)
@vspetrov vspetrov force-pushed the v5.0.x_coll_ucc_build_fix branch from e2a59e6 to feb33f7 Compare April 1, 2022 06:19
@vspetrov
Copy link
Author

vspetrov commented Apr 1, 2022

@janjust i've made a cherry-pick, you are right

@awlauria awlauria merged commit a8eb53e into open-mpi:v5.0.x Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants