Fix GCC checks to use the vendor name #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I stumbled on this one by accident today while bouncing between GNU and PGI compilers. It shouldn't impact too many folks, but good cleanup to do. |
|
Hello Josh, can you remove the existing call to _HWLOC_C_COMPILER_VENDOR([hwloc_c_vendor]) a bit later in the same HWLOC_SETUP_CORE? |
* The PGI compiler is identified as a GCC compiler (so `$GCC == yes`) This can cause problems if the user accidentally adds `--enable-picky` or if the `$GCC` variable is used to check if it is safe to add GCC specific compiler flags. * Instead of using `$GCC` we can use the vendor string returned by `_HWLOC_C_COMPILER_VENDOR`. Signed-off-by: Joshua Hursey <[email protected]>
jjhursey
force-pushed
the
fix-picky-pgi
branch
from
3ef6d4a to
f9d1e22
Compare
|
Done. I just repushed. |
bgoglin
approved these changes
Jan 7, 2021
|
Thanks Josh, I backported to v2.4 too. If you want it in OMPI, you can take the whole v2.4 branch (there 4 bugfixes since 2.4.0, other commits don't touch the library code). If you need it in another stable branch, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$GCC == yes)This can cause problems if the user accidentally adds
--enable-pickyor if the
$GCCvariable is used to check if it is safe to add GCCspecific compiler flags.
$GCCwe can use the vendor string returned by_HWLOC_C_COMPILER_VENDOR.