-
Notifications
You must be signed in to change notification settings - Fork 31
feat: spec-0.3.0 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spec-0.3.0 #40
Conversation
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
…the client Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
# Conflicts: # open_feature/open_feature_client.py
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]> Signed-off-by: Andrew Helsby <[email protected]>
|
The commits specific to 0.3.0 seem fine, but I've left a few comments on the PR for the 0.2.0 updates which can be seen in this PR. Can we cherry pick the 0.3.0 commit onto a clean branch or does it rely on previous commits? |
| merged_hooks = ( | ||
| self.provider.get_provider_hooks() | ||
| + flag_evaluation_options.hooks | ||
| + self.hooks | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will eventually want to implement the API-level hooks.
Signed-off-by: OpenFeature Bot <[email protected]>
This PR
Adds all the features required to reach compliance with spec 0.3.0
Related Issues
Fixes #8
Notes
Follow-up Tasks
How to test