fix!: raise error if the flag wasn't found using the in-memory provider #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
beeme1mr
requested review from
federicobond,
jamescarr,
tcarrio and
toddbaert
Member
|
@beeme1mr writes Python now 😎 |
toddbaert
approved these changes
Nov 1, 2023
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Makes sense to me conceptually.
Member
|
Looks like some of the gherkin tests are failing due to the InMemoryFlag change, could you update those so it's ready to merge? |
Member
Author
|
@federicobond I'll try 😟 |
Signed-off-by: Michael Beemer <[email protected]>
Signed-off-by: Michael Beemer <[email protected]>
Member
Author
|
It was easier than I thought... perhaps I am a Python developer now 😄 |
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 93.63% 93.84% +0.21%
==========================================
Files 16 16
Lines 440 439 -1
==========================================
Hits 412 412
+ Misses 28 27 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Nov 1, 2023
kikihakiem
pushed a commit
to ResalApps/openfeature-python-sdk
that referenced
this pull request
Aug 28, 2025
…1.5 (open-feature#228) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
I marked this as a breaking fix because it changes the method signature of the in-memory provider. Since we're sub-1.0, this will be treated as a minor version change, but highlight the change more predominately in the change log.
I originally intended to only remove the duplicate keys in this PR. If you would prefer that I split these into two separate PRs, please let me know.