Skip to content

fix: return correct type object in OpenFeatureClient._create_provider_evaluation #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
toddbaert merged 2 commits into from
Jul 6, 2023
Merged

fix: return correct type object in OpenFeatureClient._create_provider_evaluation #136

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9367cb
fix: return correct type object in OpenFeatureClient._create_provider…
federicobond Jul 6, 2023
7d9909a
Merge branch 'main' into fix-provider-evaluation
toddbaert Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 18 additions & 9 deletions open_feature/open_feature_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
from open_feature.flag_evaluation.flag_evaluation_options import FlagEvaluationOptions
from open_feature.flag_evaluation.flag_type import FlagType
from open_feature.flag_evaluation.reason import Reason
from open_feature.flag_evaluation.resolution_details import FlagResolutionDetails
from open_feature.hooks.hook import Hook
from open_feature.hooks.hook_context import HookContext
from open_feature.hooks.hook_support import (
Expand All @@ -26,19 +27,20 @@

GetDetailCallable = typing.Union[
typing.Callable[
[str, bool, typing.Optional[EvaluationContext]], FlagEvaluationDetails[bool]
[str, bool, typing.Optional[EvaluationContext]], FlagResolutionDetails[bool]
],
typing.Callable[
[str, int, typing.Optional[EvaluationContext]], FlagEvaluationDetails[int]
[str, int, typing.Optional[EvaluationContext]], FlagResolutionDetails[int]
],
typing.Callable[
[str, float, typing.Optional[EvaluationContext]], FlagEvaluationDetails[float]
[str, float, typing.Optional[EvaluationContext]], FlagResolutionDetails[float]
],
typing.Callable[
[str, str, typing.Optional[EvaluationContext]], FlagEvaluationDetails[str]
[str, str, typing.Optional[EvaluationContext]], FlagResolutionDetails[str]
],
typing.Callable[
[str, dict, typing.Optional[EvaluationContext]], FlagEvaluationDetails[dict]
[str, typing.Union[dict, list], typing.Optional[EvaluationContext]],
FlagResolutionDetails[typing.Union[dict, list]],
],
]

Expand Down Expand Up @@ -356,13 +358,20 @@ def _create_provider_evaluation(
if not get_details_callable:
raise GeneralError(error_message="Unknown flag type")

value = get_details_callable(*args)
resolution = get_details_callable(*args)

# we need to check the get_args to be compatible with union types.
is_right_instance = isinstance(
value.value, typing.get_args(flag_type.value)
) or isinstance(value.value, flag_type.value)
resolution.value, typing.get_args(flag_type.value)
) or isinstance(resolution.value, flag_type.value)
if not is_right_instance:
raise TypeMismatchError()

return value
return FlagEvaluationDetails(
flag_key=flag_key,
value=resolution.value,
variant=resolution.variant,
reason=resolution.reason,
error_code=resolution.error_code,
error_message=resolution.error_message,
)