Skip to content

Conversation

@jamescarr
Copy link
Contributor

This PR

Related Issues

Fixes #99

Notes

Follow-up Tasks

How to test

@jamescarr
Copy link
Contributor Author

This simply provides the scaffolding:

  • test-harness submodule
  • python step definitions that raise NotImplemented
  • Makefile target to run them: make e2e
    image

@toddbaert
Copy link
Member

Awesome work @jamescarr !

I know this is just a draft for now, but it's great to see the cuke parsing/testing working.

@federicobond
Copy link
Member

@jamescarr do you mind if I take a look at this and see if I can get it to work with the new InMemoryProvider?

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #132 (097eafe) into main (5e7bf1f) will increase coverage by 0.33%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
+ Coverage   93.83%   94.16%   +0.33%     
==========================================
  Files          23       25       +2     
  Lines         438      463      +25     
==========================================
+ Hits          411      436      +25     
  Misses         27       27              
Flag Coverage Δ
unittests 94.16% <100.00%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
open_feature/open_feature_client.py 95.91% <ø> (ø)
open_feature/provider/in_memory_provider.py 98.14% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@federicobond
Copy link
Member

Rebased against latest main after checking in with @jamescarr and managed to get the evaluation tests to pass with an InMemoryProvider.

I had to fix a couple of minor issues with the design of the provider and also found a bug in the typechecking for python<3.10.

@toddbaert toddbaert changed the title Draft: feat: E2E Test Support chore: E2E Test Support Aug 14, 2023
@toddbaert toddbaert self-requested a review August 14, 2023 14:36
Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM, I have a couple minor comments/questions.

I changed the title to "chore" since this doesn't appear to be an "end-user"-facing feature... it's more of a feature for us as OpenFeature devs.

Thanks to both if you for your efforts. Much appreciated as always 🙏 @federicobond @jamescarr

@jamescarr jamescarr marked this pull request as ready for review August 18, 2023 13:38
@federicobond federicobond merged commit 43ce93d into open-feature:main Aug 30, 2023
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…pen-feature#132)

We do have a default OpenFeature Renovate configuration within our community-tooling
repository. (https://github.com/open-feature/community-tooling/blob/main/renovate.json)

To reduce maintenance efforts, we should stick to the general one as a basis.

Signed-off-by: Simon Schrottner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create end-to-end test suite

3 participants