-
Notifications
You must be signed in to change notification settings - Fork 31
chore: E2E Test Support #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Awesome work @jamescarr ! I know this is just a draft for now, but it's great to see the cuke parsing/testing working. |
|
@jamescarr do you mind if I take a look at this and see if I can get it to work with the new InMemoryProvider? |
59bd79e to
22416cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #132 +/- ##
==========================================
+ Coverage 93.83% 94.16% +0.33%
==========================================
Files 23 25 +2
Lines 438 463 +25
==========================================
+ Hits 411 436 +25
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
4b27358 to
6d310f0
Compare
|
Rebased against latest main after checking in with @jamescarr and managed to get the evaluation tests to pass with an InMemoryProvider. I had to fix a couple of minor issues with the design of the provider and also found a bug in the typechecking for python<3.10. |
toddbaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Largely LGTM, I have a couple minor comments/questions.
I changed the title to "chore" since this doesn't appear to be an "end-user"-facing feature... it's more of a feature for us as OpenFeature devs.
Thanks to both if you for your efforts. Much appreciated as always 🙏 @federicobond @jamescarr
dcde92e to
bf755ce
Compare
Signed-off-by: Federico Bond <[email protected]> Signed-off-by: James Carr <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
…with python<3.10 Signed-off-by: Federico Bond <[email protected]>
Signed-off-by: Federico Bond <[email protected]>
bf755ce to
097eafe
Compare
…pen-feature#132) We do have a default OpenFeature Renovate configuration within our community-tooling repository. (https://github.com/open-feature/community-tooling/blob/main/renovate.json) To reduce maintenance efforts, we should stick to the general one as a basis. Signed-off-by: Simon Schrottner <[email protected]>

This PR
Related Issues
Fixes #99
Notes
Follow-up Tasks
How to test