feat!: EvaluationDetails.reason should be a string, Reason enum should export default reasons per spec #126
+74
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescarr
force-pushed
the
evaluation-details-reason
branch
2 times, most recently
from
9534a2f to
2946e01
Compare
jamescarr
force-pushed
the
evaluation-details-reason
branch
from
15e9036 to
94dc60c
Compare
jamescarr
changed the title
… export default set of reasons. Signed-off-by: James Carr <[email protected]>
jamescarr
force-pushed
the
evaluation-details-reason
branch
from
94dc60c to
2d6b6cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #126 +/- ##
==========================================
+ Coverage 92.93% 93.09% +0.15%
==========================================
Files 20 20
Lines 354 362 +8
==========================================
+ Hits 329 337 +8
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
toddbaert
approved these changes
Jun 28, 2023
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
I'm a Python novice, but from a spec POV this looks right to me.
Awaiting one more review (hopefully from somebody with more Python chops 😅 )
beeme1mr
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #98
Notes
Follow-up Tasks
How to test
make test TEST=tests/test_open_feature_flag_evaluation.py