Skip to content

Conversation

@mowies
Copy link
Member

@mowies mowies commented Apr 20, 2023

This PR

  • adds a new FlagResolutionDetails class according to the spec
  • makes use of the new class in the abstract provider and the no_op provider instead of using EvaluationDetails

Fixes #97

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Merging #103 (3758aa4) into main (5259dcf) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   92.66%   92.93%   +0.26%     
==========================================
  Files          19       20       +1     
  Lines         341      354      +13     
==========================================
+ Hits          316      329      +13     
  Misses         25       25              
Flag Coverage Δ
unittests 92.93% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
open_feature/flag_evaluation/resolution_details.py 100.00% <100.00%> (ø)
open_feature/provider/no_op_provider.py 100.00% <100.00%> (ø)
open_feature/provider/provider.py 75.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mowies mowies marked this pull request as ready for review April 20, 2023 08:25
Copy link
Member

@thisthat thisthat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beeme1mr beeme1mr merged commit 68b4796 into open-feature:main Apr 24, 2023
@mowies mowies deleted the evaluation-resolution-split branch April 24, 2023 13:00
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
…pen-feature#103)

fix: object resolution for RPC and Object types, add test-harness

Signed-off-by: Simon Schrottner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Separate EvaluationDetails from ResolutionDetails

4 participants