fix: helm sidecar resources not applied #639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
a team,
Kavindu-Dodan,
bacherfl,
beeme1mr and
odubajDT
toddbaert
commented
May 14, 2024
toddbaert
commented
May 14, 2024
Kavindu-Dodan
approved these changes
May 14, 2024
Contributor
Kavindu-Dodan
left a comment
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
LGTM
Basically we have two options to configure injected flagd's resource requests,
- From operator Helm (once this PR fix the bug)
- Through
FeatureFlagSourceresources where we can override this per deployment
I think we need to document these concepts :)
beeme1mr
approved these changes
May 14, 2024
thisthat
approved these changes
May 15, 2024
odubajDT
approved these changes
May 15, 2024
Signed-off-by: Todd Baert <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
toddbaert
force-pushed
the
fix/helm-sidecare-resources
branch
from
09f4e5a to
66a0827
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't correctly overlaying these in helm. I've added them similarly to others, using the same defaults from from here.
Fixes: #630
Manually tested and works as expected as well.