feat: allow method to be passed into setContext hook #1301
Conversation
Summary of ChangesHello @MattIPv4, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enhances the useContextMutator hook by allowing setContext to accept a function, similar to React's useState setter. This provides a more flexible way to update the context based on its previous state. The implementation is sound and is accompanied by relevant test cases. I've found one potential issue regarding a missing dependency in a useCallback hook which could lead to stale closures.
MattIPv4
force-pushed
the
feat/set-context-hook-method
branch
from
00e3973 to
80c6528
Compare
Signed-off-by: MattIPv4 <[email protected]>
Signed-off-by: MattIPv4 <[email protected]>
MattIPv4
force-pushed
the
feat/set-context-hook-method
branch
from
80c6528 to
9de51c7
Compare
…#1305) ## This PR Updates the no-op logic in useContextMutator's setContext method to compare against the actual previous context as returned by OpenFeature itself, rather than just the previous context that that specific use of useContextMutator had in its ref (#1301 (comment)). Building on #1301, this should allow for setContext to be called with a method, and for that method to return the context it was provided, to guarantee a no-op always. Signed-off-by: MattIPv4 <[email protected]> Co-authored-by: Lukas Reining <[email protected]>
🤖 I have created a release *beep* *boop* --- ## [1.1.0](react-sdk-v1.0.2...react-sdk-v1.1.0) (2025-12-09) ### ✨ New Features * allow method to be passed into setContext hook ([#1301](#1301)) ([279f9bf](279f9bf)) ### 🐛 Bug Fixes * await context change in useContextMutator setContext ([#1306](#1306)) ([7ef721a](7ef721a)) * compare full EvaluationDetails to prevent stale data ([#1287](#1287)) ([8133a4f](8133a4f)) * in-line docs, un-needed AbortController creation ([#1291](#1291)) ([9b05be9](9b05be9)) * use actual previous context to noop useContextMutator setContext ([#1305](#1305)) ([4d15a86](4d15a86)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
3 participants
This PR
Allows for
setContextreturned by theuseContextMutatorhook to be passed a method that returns the new context, with the current (previous) context passed into it. This aligns the signature ofsetContextto the setter of a regularuseStatehook, making it easier to conditionally update the context without needing to keep track of the domain separately from the React context.