Skip to content

Conversation

@lucasbotingnon
Copy link
Contributor

This PR

Solves a problem with authentication using flipt-web-provider: FliptEvaluationClient using needs to receive options.authentication in camel case, not snake case.

Removed entire if statement from line 92 to line 104. This change will not affect functionality after switching to camelCase, as it will correctly format the auth.

Related Issues

Fixes #1208

How to test

Initialize the provider, and check if the web request has the Auth header:

  const provider = new FliptWebProvider(
    "NAMESPACE",
    {
      url: "URL",
      authentication: {
        clientToken: "123RANDOM_TOKEN321",
      },
    }
  );

  await OpenFeature.setProviderAndWait(provider);

@lucasbotingnon lucasbotingnon requested a review from a team as a code owner February 11, 2025 15:14
@github-actions github-actions bot requested a review from markphelps February 11, 2025 15:15
@lucasbotingnon lucasbotingnon changed the title Fix: Removed incorrect string case format from the options.authentica… fix: Removed incorrect string case format from the options.authentica… Feb 11, 2025
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@beeme1mr
Copy link
Member

Hey @lucasbotingnon, could you please sign off on your commit. It's a requirement from the CNCF. You can do it by:

  1. In your local branch, run: git rebase HEAD~1 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin bugfix/flip-web-provider-authentication-not-reaching-evaluation-client

Thanks!

@lucasbotingnon lucasbotingnon force-pushed the bugfix/flip-web-provider-authentication-not-reaching-evaluation-client branch from 0146565 to c41fde6 Compare February 11, 2025 15:40
@lucasbotingnon
Copy link
Contributor Author

Hey @lucasbotingnon, could you please sign off on your commit. It's a requirement from the CNCF. You can do it by:

  1. In your local branch, run: git rebase HEAD~1 --signoff
  2. Force push your changes to overwrite the branch: git push --force-with-lease origin bugfix/flip-web-provider-authentication-not-reaching-evaluation-client

Thanks!

Done! Ty

Copy link
Contributor

@markphelps markphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @lucasbotingnon !!

Copy link

@paulopiriquito paulopiriquito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lucasbotingnon ! Now we can properly use a secured endpoint for the flipt provider.

@beeme1mr beeme1mr merged commit dbd2326 into open-feature:main Feb 11, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Flipt Web provider Authentication

4 participants