feat(flagd): testcontainers instead of docker compose #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
Kavindu-Dodan,
beeme1mr,
thisthat and
toddbaert
toddbaert
reviewed
Jul 3, 2024
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerConfig.java
Show resolved
Hide resolved
toddbaert
reviewed
Jul 3, 2024
providers/flagd/src/test/java/dev/openfeature/contrib/providers/flagd/e2e/ContainerConfig.java
Outdated
Show resolved
Hide resolved
toddbaert
approved these changes
Jul 3, 2024
Member
toddbaert
left a comment
toddbaert
left a comment
There was a problem hiding this comment.
Very cool! I only have nits (formatting and comments). A very cool addition.
Signed-off-by: Simon Schrottner <[email protected]>
aepfli
force-pushed
the
feat/testcontainers-for-flagd
branch
from
cc64f8b to
05c37b0
Compare
Kavindu-Dodan
approved these changes
Jul 3, 2024
toddbaert
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacing
docker compose upwith testcontainers in tests, which will start and stop the containers automatically