Added IProgress<int> and IProgress<string> to ProgressDialog #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augustoproiete
approved these changes
Mar 25, 2020
|
Thanks @vpenades I agree with leaving the value tuples approach for a future enhancement. I'm working on getting this working on .NET Core 3.1, and the projects will be upgraded in the process and maybe we can revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, it could be possible to add even more IProgress methods with different types, or, by using new c# features like value tuples it could be possible to add something like this:
But using value tuples in that way would require upgrading the project to require C# langversion 7.2... so I left it for another day...
Closes #12