Skip to content

Conversation

@guschmue
Copy link
Contributor

No description provided.

@guschmue guschmue requested a review from jignparm May 28, 2020 04:45
@jignparm
Copy link
Contributor

Couldn't find a way to comment at the code location, so pasting the snippet below.
Should this be signatures instead? Seems to be running fine, so perhaps this variable is ignored.

       self.signitures = {
            'image_arrays': raw_images,
            'prediction': detections,
        }
        return self.signitures

Copy link
Contributor

@jignparm jignparm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See minor comment in conversation section.

However, the detection boxes look good/working, and seems like a good way to strip the DecodeBmp op, using batch_image_preprocess() (I assume). Approved!

@guschmue
Copy link
Contributor Author

signitures - good catch. But we need to spell it like this because the baseclass defines it like that and driver.export() is using it.

@guschmue guschmue merged commit 9f5d63b into master May 28, 2020
@guschmue guschmue deleted the gs/efficientdet branch June 7, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants