Fix LSTM pattern matching for version between 1.15.0 and 2.x. #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandySheriffH
changed the title
jignparm
reviewed
May 7, 2020
| ]), | ||
| ]), | ||
| ]) | ||
|
|
Contributor
There was a problem hiding this comment.
Any UT that can be re/activated to check if this new pattern is working as expected? -- or are the current tests already sufficient?
Collaborator
Author
There was a problem hiding this comment.
Current cases in test_lstm.py already covering it.
I have enabled check_lstm_count(...) in common.py to capture issues.
guschmue
approved these changes
May 8, 2020
| ]), | ||
| ]) | ||
|
|
||
| xc_pattern_optimized = \ |
Contributor
There was a problem hiding this comment.
why is the name _optimized ?
Collaborator
Author
There was a problem hiding this comment.
@guschmue :
My understanding is for tf >= 1.15.0 when bias is all zero, "BiasAdd" will be optimized to "Identity" by tf optimizer, hence the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tentative fix with trivial change to match LSTM for version between 1.15.0 and 2.x.
Addressing issue #861