fix some transpose optimizer bugs #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbcsm
reviewed
Mar 26, 2019
| self._g.replace_all_inputs(ops, node.output[0], trans.input[0]) | ||
|
|
||
| shape = self._g.get_shape(node.output[0]) | ||
| dtype = self._g.get_dtype(node.output[0]) |
Collaborator
There was a problem hiding this comment.
please add tests to cover these cases.
Collaborator
Author
There was a problem hiding this comment.
1 transpose node is graph output has been covered by test_transpose_leaky_relu
2 identity is graph output is covered by new-added test case "test_transpose_with_identity"
pengwa
approved these changes
Mar 27, 2019
zhijxu-MS
force-pushed
the
tmp_branch_for_PR3
branch
from
ef4a834 to
2594eca
Compare
it's ok in local env, while in unit test the target info is not given so disable them for now
nbcsm
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix transpose optimizer bug
node can't be removed directly when graph output comes from it