Skip to content

Conversation

@jcwchen
Copy link
Member

@jcwchen jcwchen commented Aug 15, 2023

Bump ONNX 1.14.1 in CIs

Verify ONNX 1.14.1 rc2. Closes #2217.

Signed-off-by: jcwchen <[email protected]>
@jcwchen jcwchen marked this pull request as draft August 15, 2023 16:14
@jcwchen
Copy link
Member Author

jcwchen commented Aug 15, 2023

The only failed test is tests/keras2onnx_unit_tests/test_cgan.py::test_CGAN due to

Error log

onnxruntime.capi.onnxruntime_pybind11_state.Fail: [ONNXRuntimeError] : 1 : FAIL : Load model from /home/vsts/work/1/s/tests/keras2onnx_unit_tests/temp/temp_model_2.onnx failed:/onnxruntime_src/onnxruntime/core/graph/model_load_utils.h:47 void onnxruntime::model_load_utils::ValidateOpsetForDomain(const std::unordered_map, int>&, const onnxruntime::logging::Logger&, bool, const string&, int) ONNX Runtime only *guarantees* support for models stamped with official released onnx opset versions. Opset 18 is under development and support for this is limited. The operator schemas and or other functionality may change before next ONNX release and in this case ONNX Runtime will not guarantee backward compatibility. Current official support for domain ai.onnx is till opset 16.

The error only happens in ancient tf-1.15 and I guess tf-1.15 might only work with older version of onnxruntime? I also saw tf-1.15 will be removed in #2216. To confirm, @fatcat-z is this test failure related to ONNX 1.14.1? If not , ONNX 1.14.1 rc2 should be good with tf2onnx.

@fatcat-z
Copy link
Collaborator

The only failed test is tests/keras2onnx_unit_tests/test_cgan.py::test_CGAN due to

Error log
The error only happens in ancient tf-1.15 and I guess tf-1.15 might only work with older version of onnxruntime? I also saw tf-1.15 will be removed in #2216. To confirm, @fatcat-z is this test failure related to ONNX 1.14.1? If not , ONNX 1.14.1 rc2 should be good with tf2onnx.

No, tf 1.15 will be the only version of tf 1.x to be kept in CI for a long time. That pr aims to check CI failures after upgrade tf, onnx and onnxruntime to latest version.

This error has no relationship to onnx 1.14.1 RC2, so you can TF2ONNX as Green.

@fatcat-z
Copy link
Collaborator

I've updated test code as well, now it can pass.

@jcwchen jcwchen marked this pull request as ready for review August 28, 2023 16:26
@jcwchen jcwchen changed the title [WIP] Verify ONNX 1.14.1 rc2 Bump ONNX 1.14.1 Aug 28, 2023
@jcwchen
Copy link
Member Author

jcwchen commented Aug 28, 2023

cc @fatcat-z for review. Thanks!

@fatcat-z fatcat-z merged commit d5b7f39 into onnx:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please verify 1.14.1 ONNX release candidate on TestPyPI

2 participants