Fix ResizeBilinear and ResizeNearestNeighbor and update related tests #2130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cosineFish
commented
Mar 4, 2023
cosineFish
commented
- Fix tf ResizeBilinear and ResizeNearestNeighbor op with align_corners=True or half_pixel_centers=True
- Update related tests to make input data include x.5 and add tests for align_corners=True
|
This PR is ready for review but there are two failed checks. |
fatcat-z
reviewed
Mar 14, 2023
| # TensorRT only supports nearest_mode = "floor" for mode = "nearest" | ||
| transformation_mode = "half_pixel" | ||
| nearest_mode = "round_prefer_ceil" | ||
| transformation_mode = "tf_half_pixel_for_nn" |
There was a problem hiding this comment.
Is this name for debug?
There was a problem hiding this comment.
Which name? tf_half_pixel_for_nn? There is no name for debug. All of them are valid attributes of onnx Resize op.
https://github.com/onnx/onnx/blob/main/docs/Changelog.md#resize-11
|
Please fix DCO issue. |
1) Fix tf ResizeBilinear and ResizeNearestNeighbor op with align_corners=True or half_pixel_centers=True 2) Update related tests to make input data include x.5 and add tests for align_corners=True Signed-off-by: cosine <[email protected]>
Fixed. |
fatcat-z
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.