Add tf custom op conversion example #1878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hwangdeyu <[email protected]>
fatcat-z
reviewed
Mar 14, 2022
fatcat-z
reviewed
Mar 14, 2022
fatcat-z
reviewed
Mar 14, 2022
|
This pull request introduces 1 alert when merging 561765d into 8f2e84b - view on LGTM.com new alerts:
|
hwangdeyu
force-pushed
the
custom_op
branch
3 times, most recently
from
04cce83 to
ffe7769
Compare
Signed-off-by: hwangdeyu <[email protected]> Co-authored-by: fatcat-z <[email protected]>
|
This pull request introduces 1 alert when merging 6c5523c into 8f2e84b - view on LGTM.com new alerts:
|
guschmue
reviewed
Mar 14, 2022
| x_ = AddOne.add_one(x) | ||
| _ = tf.identity(x_, name="output") | ||
|
|
||
| onnx_graph = tf2onnx.tfonnx.process_tf_graph(sess.graph, |
Contributor
There was a problem hiding this comment.
don't use the OLD api !!!
Contributor
Author
There was a problem hiding this comment.
will change a new example and use tf2 api
guschmue
reviewed
Mar 14, 2022
| node.input.append(const_one) | ||
|
|
||
|
|
||
| with tf.compat.v1.Session() as sess: |
guschmue
reviewed
Mar 14, 2022
| */ | ||
|
|
||
| #include "tensorflow/core/framework/op.h" | ||
| #include "tensorflow/core/framework/shape_inference.h" |
Contributor
There was a problem hiding this comment.
I don't understand the purpose of this example.
A tf2onnx user will already have the tensorflow custom op, aka this code here he already has it.
Should the example not be AddOne in onnxruntime ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tf custom op conversion example
Signed-off-by: hwangdeyu [email protected]