Skip to content

Conversation

xadupre
Copy link
Collaborator

@xadupre xadupre commented Aug 6, 2021

The previous implementation did not apply on tensors with 3+ dimensions, only 2D tensors. This PR fixes this.

Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
@xadupre xadupre added the bug An unexpected problem or unintended behavior label Aug 6, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 10, 2021

This pull request introduces 2 alerts when merging c6f4ab9 into becdcba - view on LGTM.com

new alerts:

  • 2 for Unused local variable

Signed-off-by: xavier dupré <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request introduces 2 alerts when merging 2d2fb26 into e00594d - view on LGTM.com

new alerts:

  • 2 for Unused local variable

Signed-off-by: xavier dupré <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request introduces 2 alerts when merging a47f590 into e00594d - view on LGTM.com

new alerts:

  • 2 for Unused local variable

Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request introduces 1 alert when merging a6f3cbf into 9e48a44 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@xadupre xadupre changed the title [WIP] Update RFFT2D to handle 3D arrays Update RFFT2D to handle 3D arrays Aug 12, 2021
sdpython and others added 4 commits August 12, 2021 14:52
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
Signed-off-by: xavier dupré <[email protected]>
@xadupre xadupre merged commit e912e11 into onnx:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants