Move check earlier to fix loop in transpose optimizer #1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wildenhain <[email protected]>
|
|
||
| def _handle_node_having_branches(self, trans, node): | ||
| if not self._should_push_transpose(trans, node): | ||
| if not self._should_push_transpose(trans, node) or len(node.output) != 1: |
There was a problem hiding this comment.
This check needs to be moved before the transpose pair creation. Otherwise, pairs can be created unnecessarily which need to be removed. The removal actually causes an infinite loop in the optimizer. Technically some of the other checks need to be moved too, or the pairs destroyed on failure.
guschmue
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wildenhain [email protected]