Skip to content

Conversation

TomWildenhain-Microsoft
Copy link
Collaborator

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Jul 1, 2021

This pull request introduces 20 alerts when merging d0a34c7 into d18d3f7 - view on LGTM.com

new alerts:

  • 11 for Unused import
  • 3 for Unused local variable
  • 2 for Unreachable code
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Except block handles 'BaseException'
  • 1 for Nested loops with same variable

@guschmue
Copy link
Contributor

guschmue commented Jul 1, 2021

our root dir gets full with keras* ... could we move this to tests/ ?

@TomWildenhain-Microsoft
Copy link
Collaborator Author

our root dir gets full with keras* ... could we move this to tests/ ?

Sure. Should I move keras2onnx_tests as well?

@guschmue
Copy link
Contributor

guschmue commented Jul 1, 2021

yes, that would be awesome

@guschmue guschmue enabled auto-merge (squash) July 2, 2021 17:26
@lgtm-com
Copy link

lgtm-com bot commented Jul 2, 2021

This pull request introduces 20 alerts when merging b93f366 into 106b85b - view on LGTM.com

new alerts:

  • 11 for Unused import
  • 3 for Unused local variable
  • 2 for Unreachable code
  • 2 for Module is imported with 'import' and 'import from'
  • 1 for Except block handles 'BaseException'
  • 1 for Nested loops with same variable

@TomWildenhain-Microsoft TomWildenhain-Microsoft force-pushed the tom/keras2onnx_application_tests branch 2 times, most recently from 2ab7ef6 to 09548e3 Compare July 3, 2021 02:28
Signed-off-by: Tom Wildenhain <[email protected]>
@TomWildenhain-Microsoft TomWildenhain-Microsoft force-pushed the tom/keras2onnx_application_tests branch from 09548e3 to 08ae835 Compare July 3, 2021 06:03
Signed-off-by: Tom Wildenhain <[email protected]>
@TomWildenhain-Microsoft TomWildenhain-Microsoft force-pushed the tom/keras2onnx_application_tests branch from 6b355bc to f9250d9 Compare July 3, 2021 20:18
@guschmue guschmue merged commit feb2dcc into master Jul 6, 2021
@guschmue guschmue deleted the tom/keras2onnx_application_tests branch July 6, 2021 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants