Skip to content

Conversation

guschmue
Copy link
Contributor

Signed-off-by: Guenther Schmuelling [email protected]

Signed-off-by: Guenther Schmuelling <[email protected]>
Copy link
Collaborator

@TomWildenhain-Microsoft TomWildenhain-Microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we might want to move this inside tf2onnx so it gets pip installed (something like tf2onnx.optimize(model)) but for now looks good.

@guschmue
Copy link
Contributor Author

guschmue commented May 26, 2021

yeap, agree. I guess we need to figure if our optimizations would help pytorch exporter. The tool prints some stats. Maybe I can run this on some huggingface models.

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2021

This pull request introduces 4 alerts when merging 684fb67 into 5e0b4f3 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented May 26, 2021

This pull request introduces 1 alert when merging 31adf27 into cba8f8d - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

@guschmue guschmue merged commit 2f9078e into master May 27, 2021
@guschmue guschmue deleted the gs/onnx-optimizer-cmd branch May 27, 2021 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants