Skip to content

Fix Conv for unknown input rank #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2021
Merged

Fix Conv for unknown input rank #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tf2onnx/onnx_opset/nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ def any_version(cls, opset, ctx, node, **kwargs):

# prefix with batch dim of [1] to satisfy rank requirements
input_shape = ctx.get_shape(node.input[0])
if len(input_shape) == spatial + 1:
if input_shape is not None and len(input_shape) == spatial + 1:
gb = GraphBuilder(ctx)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I'm not sure why this condition is here and if it ever triggers. The unit tests I tried don't run it.

usq_node = gb.make_unsqueeze({"axes": [0], 'data': node.input[0]}, return_node=True)
ctx.replace_inputs(node, [usq_node.output[0]] + node.input[1:])
Expand Down