Added handlers for tflite #1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 13 alerts when merging 8cce0ba into 99eb959 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
force-pushed
the
tom/tflite_handlers
branch
from
8cce0ba to
d46fb97
Compare
|
This pull request introduces 1 alert when merging d46fb97 into 99eb959 - view on LGTM.com new alerts:
|
TomWildenhain-Microsoft
force-pushed
the
tom/tflite_handlers
branch
2 times, most recently
from
efa257d to
478458c
Compare
Signed-off-by: Tom Wildenhain <[email protected]>
TomWildenhain-Microsoft
force-pushed
the
tom/tflite_handlers
branch
from
478458c to
743f6fc
Compare
guschmue
requested changes
Jan 14, 2021
| @@ -0,0 +1,11 @@ | |||
| # Copyright (c) Microsoft Corporation. All rights reserved. | |||
| # Licensed under the MIT license. | |||
| """tf2onnx.tflite_handlers module""" | |||
There was a problem hiding this comment.
I think all of the tflite code should not start at the root dir and be under tf2onnx.
The structure at the root is something like src, tests, tools and in our case src=tf2onnx and all tflite code should go there.
There was a problem hiding this comment.
When flatbuffer generates the interface scripts, they all import each other with lines like from tflite.OperatorCode import OperatorCode and will fail if tflite isn't in the root, but I can find/replace them to fix this.
guschmue
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wildenhain [email protected]