Bug fixes for opset 13 support #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| def test_duplicated_duplicated_attributes(self): | ||
| # same attr or not | ||
| node0 = helper.make_node('ReduceSum', inputs=["X"], outputs=["value0"], axes=[0], keepdims=0) |
There was a problem hiding this comment.
ReduceMin doesn't change in opset 13 and is equally effective for testing.
| # pro-process inputs and attr | ||
| if kwargs: | ||
| logger.warning("kwargs contains un-used key") | ||
| utils.make_sure(not kwargs, "kwargs contains un-used key") |
There was a problem hiding this comment.
If the call uses the wrong kwargs, there is a problem with the tf2onnx code. This should be an error.
Signed-off-by: Tom Wildenhain <[email protected]>
TomWildenhain-Microsoft
force-pushed
the
tom/opset13fixes
branch
from
b75c58b to
e58a087
Compare
guschmue
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Wildenhain [email protected]