Add cast to same type before equal operator #1089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bedapisl
changed the title
bedapisl
force-pushed
the
fix_equal
branch
2 times, most recently
from
5cd7db5 to
4bf83c8
Compare
bedapisl
changed the title
TomWildenhain-Microsoft
suggested changes
Sep 11, 2020
tests/test_equal.py
Outdated
|
|
||
| class EqualTests(Tf2OnnxBackendTestBase): | ||
|
|
||
| def test_equal_with_different_parameters(self): |
There was a problem hiding this comment.
Put this test in test_backend.py under test_equal.
bedapisl
force-pushed
the
fix_equal
branch
2 times, most recently
from
f100430 to
030abc7
Compare
Signed-off-by: bedapisl <[email protected]>
Signed-off-by: bedapisl <[email protected]>
TomWildenhain-Microsoft
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for example this model: https://drive.google.com/file/d/105xs9j1PjzKk45PkM5-hGNKxGTdElsCL/view?usp=sharing to be correctly converted and loaded with onnxruntime. Without the proposed changes the converted model is not valid (microsoft/onnxruntime#4997).