Skip to content
This repository was archived by the owner on Nov 5, 2024. It is now read-only.

Conversation

@adbario
Copy link
Contributor

@adbario adbario commented Sep 20, 2022

Description

#186 Fixes the scoping issue of transaction props, but this needs to be done for executing the scripts as well. Executing scripts using the bundle won't work without the fix, so would be great to have a new release once this gets merged.

These bundle-related issues can't be seen by running the test suite, as the tests use the source code.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation - no relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@adbario adbario requested a review from a team as a code owner September 20, 2022 01:39
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: c072d9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@onflow/flow-js-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@adbario
Copy link
Contributor Author

adbario commented Sep 20, 2022

@justinbarry Mind looking at this when you have a moment, as executing scripts is currently blocked on the latest version?

Thanks 👍

@jribbink
Copy link
Contributor

jribbink commented Oct 21, 2022

I'm fairly certain that simply merging this PR should fix #191 & #182. @gregsantos

@adbario
Copy link
Contributor Author

adbario commented Oct 21, 2022

I'm fairly certain that simply merging this PR should fix #191 & #182. @gregsantos

Yes, both of those issues should be solved by this.

Would be great to have PRs #177 and #188 as well merged at some point to solve couple of deprecation warnings.

@gregsantos
Copy link

Thanks folks, will try to get these reviewed and merged asap

Copy link

@gregsantos gregsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, looks good

@gregsantos gregsantos merged commit 1ce23f0 into onflow:master Oct 24, 2022
This was referenced Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants