Skip to content

fix: should wait for button click when both asSingle and showFooter are true #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix: should wait for button click when both asSingle and showFooter are true #229

merged 1 commit into from
Aug 13, 2024

Conversation

@Elbarae1921
Copy link
Contributor

@Elbarae1921 Elbarae1921 commented Jan 30, 2024

This PR addresses #140.

Problem: When asSingle is enabled, the datepicker ignores showFooter and submits when a value is picked instead of waiting for button click.

Solution: check if showFooter is enabled before submitting.

@Elbarae1921 Elbarae1921 mentioned this pull request Jan 30, 2024
Closed
@onesine
Copy link
Owner

onesine commented Aug 13, 2024

Hi @Elbarae1921 👋.
Sorry for the late reply.
Thanks for the contribution.

@onesine onesine merged commit 807982b into onesine:master Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Elbarae1921 @onesine