Skip to content

[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbenzie merged 1 commit into from
Aug 29, 2023
Merged

[EXP][CMDBUF] Add fill commands to cmd buffer experimental feature #818

kbenzie merged 1 commit into from
Aug 29, 2023

Conversation

@Bensuo
Copy link
Contributor

@Bensuo Bensuo commented Aug 23, 2023 •
edited
Loading

  • Adds USM and Buffer fill append commands
  • Update feature spec for new commands
  • Aligns Append* naming conventions with core equivalents

EwanC
EwanC reviewed Aug 24, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nitpickings, but one comment about valid inputs for patternSize parameter

@Bensuo Bensuo force-pushed the cmd-buffer-fill branch 2 times, most recently from 66ebb2e to 27b39c4 Compare August 24, 2023 16:14
EwanC
EwanC approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kbenzie
kbenzie approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@kbenzie kbenzie left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So my two comments about naming conventions don't need to block this PR but they should be made consistent with enquivelent enqueue entry point naming before command buffers come out of experimental support.

@Bensuo
[CMDBUF] Add fill commands to cmd buffer exp feature
40a6846 
- Adds USM and Buffer fill append commands
- Update feature spec for new commands
- Align naming conventions for Append* commands with core equivalents
@Bensuo
Copy link
Contributor Author

Bensuo commented Aug 28, 2023

So my two comments about naming conventions don't need to block this PR but they should be made consistent with enquivelent enqueue entry point naming before command buffers come out of experimental support.

Good catch! I've just addressed these as part of this PR for simplicity, they should be well aligned now.

@Bensuo Bensuo mentioned this pull request Aug 28, 2023
Merged
@kbenzie kbenzie merged commit 19f391b into oneapi-src:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@veselypeta veselypeta veselypeta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Bensuo @kbenzie @EwanC @veselypeta