Mirror intel/llvm commits #2760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrated from #2622 All handles from all backends are now required to implement `ddi_getter` and their first field must be a pointer to a `ur_ddi_table_t` (which also implies that they must not have a vtable). Instead of wrapping handles in a special wrapper type, we instead query the DDI table stored in the handle itself. This simplifies the loader greatly.
- Inline createProgram function in CUDA adapter, and catch ur result exceptions in both adapters. - Fix pattern of unnecessarily storing error code in a variable instead of just returning it. - Fix incorrect setErrorMessage uses, the adapter specific code signals that there is a specific error code and message in get last error, it doesn't make sense to use it as the code in the last error. - Remove now unrelated comment on now removed primary context extension. - Don't use `unique_ptr` when `delete` is enough.
This variable isn't actually read anywhere.
Add a note to suggest checking if UR_CONFORMANCE_TARGET_TRIPLES includes the requested target. Depends on: intel/llvm#18279
…… (#18429) …r v2) from loader (#17536)" This reverts commit b0b48a409ec5b6efde1f774dfa19f43307aa2a72 (except for test changes). The internal testing failed because the L0 loader used, was older than 1.21.2 (and didn't have leak checking implemented). I did not revert changes in the tests as that doesn't make any difference and it will be easier to reapply the patch in the future.
github-actions
bot
added
ci/cd
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide will be updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be marked with the Should you wish to continue with your PR you will need to migrate it to intel/llvm. If your PR should remain open and not be closed automatically, you can remove the This is an automated comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action