Skip to content

Update MemBufferCreate with unsupported checks #2562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Update MemBufferCreate with unsupported checks #2562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 23 additions & 29 deletions test/conformance/memory/urMemBufferCreateWithNativeHandle.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,16 @@ using urMemBufferCreateWithNativeHandleTest = uur::urMemBufferTest;
UUR_INSTANTIATE_DEVICE_TEST_SUITE_P(urMemBufferCreateWithNativeHandleTest);

TEST_P(urMemBufferCreateWithNativeHandleTest, Success) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{}, uur::LevelZeroV2{}, uur::HIP{},
uur::NativeCPU{});

ur_native_handle_t hNativeMem = 0;
ASSERT_SUCCESS(urMemGetNativeHandle(buffer, device, &hNativeMem));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemGetNativeHandle(buffer, device, &hNativeMem));

// We cannot assume anything about a native_handle, not even if it's
// `nullptr` since this could be a valid representation within a backend.
// We can however convert the native_handle back into a unified-runtime handle
// and perform some query on it to verify that it works.
ur_mem_handle_t mem = nullptr;
ASSERT_SUCCESS(
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemBufferCreateWithNativeHandle(hNativeMem, context, nullptr, &mem));
ASSERT_NE(mem, nullptr);

Expand All @@ -34,20 +32,18 @@ TEST_P(urMemBufferCreateWithNativeHandleTest, Success) {
}

TEST_P(urMemBufferCreateWithNativeHandleTest, SuccessWithOwnedNativeHandle) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{}, uur::LevelZeroV2{}, uur::HIP{},
uur::NativeCPU{});

ur_native_handle_t native_handle = 0;
ASSERT_SUCCESS(urMemGetNativeHandle(buffer, device, &native_handle));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemGetNativeHandle(buffer, device, &native_handle));

ur_mem_handle_t mem = nullptr;
ur_mem_native_properties_t props = {
/*.stype =*/UR_STRUCTURE_TYPE_MEM_NATIVE_PROPERTIES,
/*.pNext =*/nullptr,
/*.isNativeHandleOwned =*/true,
};
ASSERT_SUCCESS(urMemBufferCreateWithNativeHandle(native_handle, context,
&props, &mem));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(urMemBufferCreateWithNativeHandle(
native_handle, context, &props, &mem));
ASSERT_NE(nullptr, mem);

ur_context_handle_t mem_context = nullptr;
Expand All @@ -58,20 +54,18 @@ TEST_P(urMemBufferCreateWithNativeHandleTest, SuccessWithOwnedNativeHandle) {
}

TEST_P(urMemBufferCreateWithNativeHandleTest, SuccessWithUnOwnedNativeHandle) {
UUR_KNOWN_FAILURE_ON(uur::CUDA{}, uur::LevelZeroV2{}, uur::HIP{},
uur::NativeCPU{});

ur_native_handle_t native_handle = 0;
ASSERT_SUCCESS(urMemGetNativeHandle(buffer, device, &native_handle));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemGetNativeHandle(buffer, device, &native_handle));

ur_mem_handle_t mem = nullptr;
ur_mem_native_properties_t props = {
/*.stype =*/UR_STRUCTURE_TYPE_MEM_NATIVE_PROPERTIES,
/*.pNext =*/nullptr,
/*.isNativeHandleOwned =*/false,
};
ASSERT_SUCCESS(urMemBufferCreateWithNativeHandle(native_handle, context,
&props, &mem));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(urMemBufferCreateWithNativeHandle(
native_handle, context, &props, &mem));
ASSERT_NE(nullptr, mem);

ur_context_handle_t mem_context = nullptr;
Expand All @@ -82,36 +76,36 @@ TEST_P(urMemBufferCreateWithNativeHandleTest, SuccessWithUnOwnedNativeHandle) {
}

TEST_P(urMemBufferCreateWithNativeHandleTest, InvalidNullHandle) {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}, uur::NativeCPU{});

ur_native_handle_t hNativeMem = 0;
ASSERT_SUCCESS(urMemGetNativeHandle(buffer, device, &hNativeMem));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemGetNativeHandle(buffer, device, &hNativeMem));

ur_mem_handle_t mem = nullptr;
ur_mem_native_properties_t props = {
/*.stype =*/UR_STRUCTURE_TYPE_MEM_NATIVE_PROPERTIES,
/*.pNext =*/nullptr,
/*.isNativeHandleOwned =*/false,
};
ASSERT_EQ(
urMemBufferCreateWithNativeHandle(hNativeMem, nullptr, &props, &mem),
UR_RESULT_ERROR_INVALID_NULL_HANDLE);
auto err =
urMemBufferCreateWithNativeHandle(hNativeMem, nullptr, &props, &mem);
ASSERT_TRUE(err == UR_RESULT_ERROR_INVALID_NULL_HANDLE ||
err == UR_RESULT_ERROR_UNSUPPORTED_FEATURE);
}

TEST_P(urMemBufferCreateWithNativeHandleTest, InvalidNullPointer) {
UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}, uur::NativeCPU{});

ur_native_handle_t hNativeMem = 0;
ASSERT_SUCCESS(urMemGetNativeHandle(buffer, device, &hNativeMem));
UUR_ASSERT_SUCCESS_OR_UNSUPPORTED(
urMemGetNativeHandle(buffer, device, &hNativeMem));

ur_mem_native_properties_t props = {
/*.stype =*/UR_STRUCTURE_TYPE_MEM_NATIVE_PROPERTIES,
/*.pNext =*/nullptr,
/*.isNativeHandleOwned =*/false,
};
ASSERT_EQ(
urMemBufferCreateWithNativeHandle(hNativeMem, context, &props, nullptr),
UR_RESULT_ERROR_INVALID_NULL_POINTER);
auto err =
urMemBufferCreateWithNativeHandle(hNativeMem, context, &props, nullptr);
ASSERT_TRUE(err == UR_RESULT_ERROR_INVALID_NULL_POINTER ||
err == UR_RESULT_ERROR_UNSUPPORTED_FEATURE);
}

using urMemBufferMultiQueueMemBufferTest = uur::urMultiDeviceMemBufferQueueTest;
Expand Down
Loading