Skip to content

Conversation

@sommerlukas
Copy link
Contributor

The code object finalization for kernel fusion uses the AMD COMGR. The location of the corresponding header changed between ROCm version 4 and 5.

This PR fixes the include for ROCm version 4.

@sommerlukas sommerlukas requested a review from a team as a code owner January 3, 2024 17:47
@sommerlukas sommerlukas requested a review from JackAKirk January 3, 2024 17:47
@sommerlukas sommerlukas force-pushed the lukas/comgr-include-rocm4 branch from 2b1d73a to 327220d Compare January 3, 2024 17:48
@sommerlukas
Copy link
Contributor Author

Pull request in intel/llvm: intel/llvm#12286

@sommerlukas sommerlukas force-pushed the lukas/comgr-include-rocm4 branch from 9d3ddd6 to d398d4a Compare January 4, 2024 09:49
@sommerlukas
Copy link
Contributor Author

The rocm_version.h header does not necessarily seem to be present ROCm/HIP installations. Changed the PR to use CMake instead to detect the correct include for the AMD COMGR.

@sommerlukas sommerlukas requested a review from JackAKirk January 4, 2024 09:50
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cf87428) 15.73% compared to head (d398d4a) 15.73%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   15.73%   15.73%           
=======================================
  Files         223      223           
  Lines       31477    31477           
  Branches     3558     3558           
=======================================
  Hits         4953     4953           
  Misses      26473    26473           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kbenzie kbenzie mentioned this pull request Jan 4, 2024
8 tasks
@kbenzie kbenzie added ready to merge Added to PR's which are ready to merge v0.8.x Include in the v0.8.x release labels Jan 4, 2024
@kbenzie kbenzie merged commit c311fe8 into oneapi-src:main Jan 4, 2024
@sommerlukas sommerlukas deleted the lukas/comgr-include-rocm4 branch January 4, 2024 15:27
kbenzie added a commit to kbenzie/unified-runtime that referenced this pull request Jan 4, 2024
…de-rocm4

[UR][HIP] Fix include for AMD COMGR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Added to PR's which are ready to merge v0.8.x Include in the v0.8.x release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants