[UR] Fix critnib on windows #1084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was assinging destination to the destination ingoring the source...
1UL is 4 bytes on windows causing wrong results with bit mask
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1084 +/- ##
=======================================
Coverage ? 16.19%
=======================================
Files ? 220
Lines ? 30793
Branches ? 3481
=======================================
Hits ? 4988
Misses ? 25755
Partials ? 50 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Testing PR on llvm: intel/llvm#11898 |
jandres742
approved these changes
Nov 15, 2023
pbalcer
approved these changes
Nov 16, 2023
omarahmed1111
approved these changes
Nov 16, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.