[CUDA][HIP] Combined CTS Fixes #1077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The UR spec was recently changed to guarantee that hint entryponts never return errors. This commit changes the CUDA adapter to be conformant with this change. - This commit also changes the type of PointerRangeSize which was causing a stack corruption.
CUDA does not make a distinction between binaryTypes (it treats PTX and binaries using the same entrypoints). However, for UR, by definition: * urProgramCompile should set the binary type to UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT * urProgramBuild / urProgramLink should set it to UR_PROGRAM_BINARY_TYPE_EXECUTABLE. * urProgramCreateWithBinary should set the binary type to UR_PROGRAM_BINARY_TYPE_COMPILED_OBJECT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the following PR's:
Tested on: intel/llvm#11880