Skip to content

Conversation

@kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Jul 1, 2024

Those flags provide extra warnings in case of discarding qualifiers or return values. This allows for the discovery of warnings/errors before they appear on UR CI (https://github.com/oneapi-src/unified-runtime/actions/runs/9712855198/job/26811966767?pr=1430).

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@kswiecicki kswiecicki force-pushed the extra-compiler-flags branch from 5fa08f4 to 1be99e3 Compare July 1, 2024 10:59
Those flags provide extra warnings in case of discarding qualifiers or
return values.
@kswiecicki kswiecicki force-pushed the extra-compiler-flags branch from 1be99e3 to 6ecffbe Compare July 1, 2024 12:49
@kswiecicki kswiecicki marked this pull request as ready for review July 1, 2024 14:06
@kswiecicki kswiecicki requested a review from a team as a code owner July 1, 2024 14:06
@bratpiorka bratpiorka requested a review from PatKamin July 1, 2024 14:10
@bratpiorka bratpiorka merged commit 685a21f into oneapi-src:main Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants