Skip to content

Conversation

mauvilsa
Copy link
Member

@mauvilsa mauvilsa commented Feb 9, 2023

What does this PR do?

Fixes #238

Before submitting

  • Did you read the contributing guideline?
  • Did you update the documentation? (readme and public docstrings)
  • Did you write unit tests such that there is 100% coverage on related code? (required for bug fixes and new features)
  • Did you verify that new and existing tests pass locally?
  • Did you make sure that all changes preserve backward compatibility?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

@mauvilsa mauvilsa added the enhancement New feature or request label Feb 9, 2023
@mauvilsa mauvilsa force-pushed the issue-238-cli-callable-instance branch from 0f1c03b to d96a151 Compare February 9, 2023 20:56
Copy link

@indigoviolet indigoviolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you for the quick fix!

@mauvilsa mauvilsa force-pushed the issue-238-cli-callable-instance branch from d96a151 to fff06cc Compare February 10, 2023 17:51
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (fff06cc) compared to base (7a184d5).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #239   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         5184      5185    +1     
=========================================
+ Hits          5184      5185    +1     
Flag Coverage Δ
py3.10 87.92% <100.00%> (+<0.01%) ⬆️
py3.10_all 99.88% <100.00%> (+<0.01%) ⬆️
py3.6 87.56% <100.00%> (+<0.01%) ⬆️
py3.6_all 99.63% <100.00%> (+<0.01%) ⬆️
py3.7 87.58% <100.00%> (+<0.01%) ⬆️
py3.7_all 99.80% <100.00%> (+<0.01%) ⬆️
py3.8 87.90% <100.00%> (+<0.01%) ⬆️
py3.8_all 99.84% <100.00%> (+<0.01%) ⬆️
py3.9 87.90% <100.00%> (+<0.01%) ⬆️
py3.9_all 99.86% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jsonargparse/cli.py 100.00% <100.00%> (ø)
jsonargparse/typehints.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mauvilsa mauvilsa merged commit dc5cdac into master Feb 10, 2023
@mauvilsa mauvilsa deleted the issue-238-cli-callable-instance branch February 10, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CLI does not work with callable component?

3 participants