Add context to logger #1542
Draft
Add context to logger #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `LoggerWithContext` interface that extends the `Logger` interface by a method `PrintfWithContext` that, when implemented, is called instead of the `Printf` method of the `Logger` interface. The purpose of `PrintfWithContext` is to receive the current context under which the logging happens. Notice that this doesn't always have to be request-scoped, i.e. an actual API call from a user. It may also be from an internal state or process, e.g. Bulk processor or node health. Close #1541
olivere
force-pushed
the
add-context-logger.issue-1541
branch
from
d01a467 to
debed67
Compare
Closed
lichunqiang
reviewed
Oct 15, 2021
|
|
||
| // LoggerWithContext extends the Logger interface by a context. | ||
| type LoggerWithContext interface { | ||
| Logger |
There was a problem hiding this comment.
I don't think about LoggerWithContext implements Logger interface is necessarily.
There was a problem hiding this comment.
Otherwise you can’t specify the logger in a backwards compatible manner with SetErrorLog etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
LoggerWithContextinterface that extends theLoggerinterface by a methodPrintfWithContextthat, whenimplemented, is called instead of the
Printfmethod of theLoggerinterface.
The purpose of
PrintfWithContextis to receive the current contextunder which the logging happens. Notice that this doesn't always
have to be request-scoped, i.e. an actual API call from a user. It may
also be from an internal state or process, e.g. Bulk processor or node
health.
Close #1541